doc: finalize statements in sqlite examples - #65088
Merged
nodejs-github-bot merged 2 commits intoAug 8, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the SQLite API documentation examples to ensure prepared statements are properly finalized/closed, reducing the risk of leaking statement handles.
Changes:
- Added explicit
.close()calls to prepared statements in introductory examples. - Replaced one-liner
prepare(...).get()usage withusingdeclarations to leverage automatic disposal. - Updated session-related examples to use
usingfor prepared statements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avivkeller
approved these changes
Aug 7, 2026
trivikr
added
doc
Renegade334
approved these changes
Aug 7, 2026
Renegade334
left a comment
Renegade334
left a comment
Member
There was a problem hiding this comment.
GitHub Actions turbo-died on this commit for some reason, it might be easier just to rebase.
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
araujogui
force-pushed
the
sqlite-statement-teardown
branch
from
August 7, 2026 20:10
a5ef016 to
e73c46b
Compare
Renegade334
approved these changes
Aug 7, 2026
trivikr
requested changes
Aug 8, 2026
trivikr
approved these changes
Aug 8, 2026
trivikr
added
commit-queue-squash
jasnell
approved these changes
Aug 8, 2026
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 862d994 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples left prepared statements to be finalized implicitly. Use
close()in the introductory example andusingin the shorter ones.Refs: #64232 (review)